Added support for sentry environment config via env var.#14
Merged
mdellabitta merged 1 commit intomainfrom Jan 1, 2025
Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 3ad73b7 in 7 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/instrumentation.ts:10
- Draft comment:
Consider verifying that the default environment value 'development' aligns with the intended use case. If 'development' is not the desired default, adjust accordingly. - Reason this comment was not posted:
Confidence changes required:33%
The use of nullish coalescing operator (??) is appropriate here to provide a default value for the environment. However, it's important to ensure that the default value aligns with the intended use case.
Workflow ID: wflow_gypaeT3ZtpXzdjzz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add support for configuring Sentry environment via
SENTRY_ENVIRONMENTenv var ininstrumentation.ts.SENTRY_ENVIRONMENTenv var ininstrumentation.ts.SENTRY_ENVIRONMENTis not set.This description was created by
for 3ad73b7. It will automatically update as commits are pushed.